cloud-fan commented on a change in pull request #28572:
URL: https://github.com/apache/spark/pull/28572#discussion_r427279021
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/EncoderResolutionSuite.scala
##########
@@ -247,6 +247,13 @@ class EncoderResolutionSuite extends PlanTest {
""".stripMargin.trim + " of the field in the target object")
}
+ test("SPARK-31750: eliminate UpCast if child's dataType is DecimalType") {
+ val encoder = ExpressionEncoder[Seq[BigDecimal]]
+ val attr = Seq(AttributeReference("a", ArrayType(DecimalType(38, 0)))())
+ // previously, it will fail because Decimal(38, 0) can not be casted to
Decimal(38, 18)
Review comment:
`previously` -> `Before SPARK-31750`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
