Ngone51 commented on a change in pull request #28572:
URL: https://github.com/apache/spark/pull/28572#discussion_r427308224
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -2439,6 +2439,17 @@ class DataFrameSuite extends QueryTest
val nestedDecArray = Array(decSpark)
checkAnswer(Seq(nestedDecArray).toDF(), Row(Array(wrapRefArray(decJava))))
}
+
+ test("SPARK-31750: eliminate UpCast if child's dataType is DecimalType") {
+ withTempPath { f =>
+ sql("select cast(11111111111111111111111111111111111111 as decimal(38,
0)) as d")
Review comment:
Yes, I've changed it to `1` to simplify the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
