Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/5014#discussion_r26635124
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala ---
@@ -557,8 +557,11 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
"TOK_TABLEPROPERTIES"),
children)
val (db, tableName) = extractDbNameTableName(tableNameParts)
-
- CreateTableAsSelect(db, tableName, nodeToPlan(query), allowExisting
!= None, Some(node))
+ if (ignores.exists(_ != None)) {
+ CreateTableAsSelect(db, tableName, nodeToPlan(query),
allowExisting != None, Some(node))
+ } else {
+ CreateTableAsSelect(db, tableName, nodeToPlan(query),
allowExisting != None, None)
--- End diff --
OK, I see. My concern of not relying on SemanticAnalyzer is for users who
also have Hive installed, they may expect that the default format is controlled
by `hive.default.fileformat`. If we pass `None` to `desc` at here, we will use
text file instead of using the one specified in `hive.default.fileformat`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
