cloud-fan commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429081944
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -684,6 +685,24 @@ object TypeCoercion {
}
}
+ /**
+ * From SPARK-16323 division operator returns Long.
+ * So need to add the rule to cast to Long if there operands are of Byte,
Short and Integer
Review comment:
how about
```
`IntegralDivision` always returns long-type value. This rule cast the
integral inputs to long type, to avoid
overflow during calculation.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
