cloud-fan commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429089026
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -684,6 +685,24 @@ object TypeCoercion {
}
}
+ /**
+ * Since SPARK-16323 `IntegralDivide` always returns long-type value.
+ * This rule cast the integral inputs to long type, to avoid overflow during
calculation.
+ */
+ object IntegralDivision extends TypeCoercionRule {
+ override protected def coerceTypes(
+ plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
+ case e if !e.childrenResolved => e
+ case d @ IntegralDivide(left, right) =>
Review comment:
Let's update `IntegralDivide.inputType`, to only accpet `LongType` and
`DecimalType`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
