cloud-fan commented on a change in pull request #28600:
URL: https://github.com/apache/spark/pull/28600#discussion_r429105908
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -684,6 +685,24 @@ object TypeCoercion {
}
}
+ /**
+ * Since SPARK-16323 `IntegralDivide` always returns long-type value.
Review comment:
This is a bit misleading. The `DIV` operator always returns long-type
values since the first day. SPARK-16323 is more like an internal perf
optimization.
How about
```
The DIV operator always returns long-type value. This rule cast ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
