maropu commented on a change in pull request #28633:
URL: https://github.com/apache/spark/pull/28633#discussion_r429787806
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -320,12 +324,23 @@ object CreateStruct extends FunctionBuilder {
})
}
+ /**
+ * Returns a named struct with a pretty SQL name. It will show the pretty
SQL string
+ * in its output column name as if `struct(...)` was called. Should be used
for an
+ * external purpose.
+ */
+ def create(children: Seq[Expression]): CreateNamedStruct = {
+ val expr = CreateStruct(children)
+ expr.setTagValue(FUNC_ALIAS, "struct")
+ expr
+ }
+
/**
* Entry to use in the function registry.
*/
val registryEntry: (String, (ExpressionInfo, FunctionBuilder)) = {
val info: ExpressionInfo = new ExpressionInfo(
- "org.apache.spark.sql.catalyst.expressions.NamedStruct",
+ classOf[CreateNamedStruct].getCanonicalName,
Review comment:
nit tnohgh, we cannot reuse the `ExpressionInfo` of `CreateNameStruct`
via reflection here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
