hvanhovell commented on a change in pull request #28633:
URL: https://github.com/apache/spark/pull/28633#discussion_r429802771
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -434,6 +449,11 @@ case class CreateNamedStruct(children: Seq[Expression])
extends Expression {
}
override def prettyName: String = "named_struct"
+
+ override def sql: String = getTagValue(FUNC_ALIAS).map { alias =>
Review comment:
Shouldn't you override prettyName as well? In general this seems to have
been solved with either a mixin or at the Expression level.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
