huaxingao commented on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-636527903
I don't think the changes in SPARK-29093 affect users. Using ```outputCols``` as an example, the common usage is like this: ``` ohe = OneHotEncoder() ohe.setInputCols(["input"]) ohe.setOutputCols(["output"]) model = ohe.fit(df) ``` It doesn't matter to the users if ```setOutputCols``` is in ```OneHotEncoder``` or in ```HasOutputCols```. Seems to me that users will not call ```HasOutputCols.setOutputCols``` directly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org