EnricoMi commented on pull request #28663: URL: https://github.com/apache/spark/pull/28663#issuecomment-637016095
The `HasOutputCols` mixin is a public mixin that users can use with other implementations of `Params`, not only `OneHotEncoder`. User code breaks and users have to dive into Spark code to find the correct replacement. That single line in the migration guide helps users to save an hour or two when moving their code to pyspark 3. In my opinion, it does not matter if this is common usage or not, it is a possible usage that breaks with this change. First place to look when your code breaks is the migration guide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
