cloud-fan commented on a change in pull request #28692:
URL: https://github.com/apache/spark/pull/28692#discussion_r433253854
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -117,7 +117,16 @@ class LegacySimpleDateFormatter(pattern: String, locale:
Locale) extends LegacyD
object DateFormatter {
import LegacyDateFormats._
- val defaultLocale: Locale = Locale.US
+ /**
+ * This is change from Locale.US to GB, because:
Review comment:
Let's make the doc shorter
```
Before Spark 3.0, the first day-of-week is always Monday. Since Spark 3.0,
it depends on the locale.
We pick GB as the default locale instead of US, to be compatible with Spark
2.x, as US locale uses
Sunday as the first day-of-week. See SPARK-31879.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
