yaooqinn commented on a change in pull request #28692: URL: https://github.com/apache/spark/pull/28692#discussion_r433258038
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ########## @@ -117,7 +117,16 @@ class LegacySimpleDateFormatter(pattern: String, locale: Locale) extends LegacyD object DateFormatter { import LegacyDateFormats._ - val defaultLocale: Locale = Locale.US + /** + * This is change from Locale.US to GB, because: + * The first day-of-week varies by culture. + * For example, the US uses Sunday, while the United Kingdom and the ISO-8601 standard use Monday. Review comment: We have `O`, `OOOO` and `ZZZZ` that are localized, but there are decided by the `zoneID`(spark.sql.session.timeZone), not related to Locate here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org