jiangxb1987 commented on a change in pull request #28746:
URL: https://github.com/apache/spark/pull/28746#discussion_r436493879
##########
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##########
@@ -74,6 +74,10 @@ class LocalSparkCluster(
def stop(): Unit = {
logInfo("Shutting down local Spark cluster.")
+ // SPARK-31922: wait one more second before shutting down rpcEnvs of
master and worker,
+ // in order to let the cluster have time to handle the
`UnregisterApplication` message.
+ // Otherwise, we could hit "RpcEnv already stopped" error.
+ Thread.sleep(1000)
Review comment:
I don't think this is ideal to handle the issue, there can always be
lags for various reasons so the error message may still appear. Ideally we
should get to know the LocalCluster is stopped on the Master side and don't
output the RpcEnv stopped error message but I'm not sure how hard it is to do
so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
