cloud-fan commented on a change in pull request #28766:
URL: https://github.com/apache/spark/pull/28766#discussion_r437833956
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/TimestampFormatterSuite.scala
##########
@@ -433,4 +433,35 @@ class TimestampFormatterSuite extends
DatetimeFormatterSuite {
assert(formatter.format(date(1970, 4, 10)) == "100")
}
}
+
+ test("SPARK-31939: Fix Parsing day of year when year field pattern is
missing") {
+ // resolved to queryable LocaleDate or fail directly
+ val f0 = TimestampFormatter("yyyy-dd-DD", UTC, isParsing = true)
Review comment:
shall we test both timestamp and date formatter? We can put the test in
the base class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
