yaooqinn commented on a change in pull request #28766:
URL: https://github.com/apache/spark/pull/28766#discussion_r437871990
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -39,6 +39,18 @@ trait DateTimeFormatterHelper {
}
}
+ private def verifyLocalDate(
+ accessor: TemporalAccessor, field: ChronoField, candidate: LocalDate):
Unit = {
+ if (accessor.isSupported(field) && candidate.isSupported(field)) {
Review comment:
For the time being, yes. I can remove this condition
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -39,6 +39,18 @@ trait DateTimeFormatterHelper {
}
}
+ private def verifyLocalDate(
+ accessor: TemporalAccessor, field: ChronoField, candidate: LocalDate):
Unit = {
+ if (accessor.isSupported(field) && candidate.isSupported(field)) {
+ val actual = accessor.get(field)
+ val expected = candidate.get(field)
+ if (actual != expected) {
+ throw new DateTimeException(s"Conflict found: Field $field $actual
differs from" +
+ s" $field $expected derived from $candidate")
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
