baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437837248
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1263,17 +1241,34 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
"trying again...")
store.close()
memoryManager.release(appId, attempt.info.attemptId)
- lease.rollback()
retried = true
-
case e: Exception =>
store.close()
memoryManager.release(appId, attempt.info.attemptId)
- lease.rollback()
throw e
}
}
+ // Create a LevelDB and start a background thread to dump data to LevelDB
+ logInfo(s"Leasing disk manager space for app $appId /
${attempt.info.attemptId}...")
Review comment:
do you mean exception thrown in the foreground thread or in the
background thread? If it's in foreground thread, we can use a try-catch block
to close the store when an exception is thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
