baohe-zhang commented on a change in pull request #28412:
URL: https://github.com/apache/spark/pull/28412#discussion_r437837726



##########
File path: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -1263,17 +1241,34 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
             "trying again...")
           store.close()
           memoryManager.release(appId, attempt.info.attemptId)
-          lease.rollback()
           retried = true
-
         case e: Exception =>
           store.close()
           memoryManager.release(appId, attempt.info.attemptId)
-          lease.rollback()
           throw e
       }
     }
 
+    // Create a LevelDB and start a background thread to dump data to LevelDB
+    logInfo(s"Leasing disk manager space for app $appId / 
${attempt.info.attemptId}...")

Review comment:
       ok, will update it. Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to