Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4850#discussion_r26803803
  
    --- Diff: 
core/src/main/scala/org/apache/spark/executor/CommitDeniedException.scala ---
    @@ -22,14 +22,12 @@ import org.apache.spark.{TaskCommitDenied, 
TaskEndReason}
     /**
      * Exception thrown when a task attempts to commit output to HDFS but is 
denied by the driver.
      */
    -class CommitDeniedException(
    +private[spark] class CommitDeniedException(
    --- End diff --
    
    Since this was inadvertently public before, and thus was public in Spark 
1.3, I think that this change will cause a MiMa failure once we bump the 
version to 1.4.0-SNAPSHOT.  Therefore, this PR sort of implicitly conflicts 
with #5056, so we'll have to make sure to re-test whichever PR we merge second.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to