Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4850#discussion_r26804299
  
    --- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
    @@ -156,12 +160,19 @@ private[spark] class Executor(
           serializedTask: ByteBuffer)
         extends Runnable {
     
    +    /** Whether this task has been killed. */
         @volatile private var killed = false
    -    @volatile var task: Task[Any] = _
    -    @volatile var attemptedTask: Option[Task[Any]] = None
    --- End diff --
    
    This `attemptedTask` vs `task` stuff in the old code is/was really 
confusing, so thanks for cleaning it up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to