cloud-fan commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r437995092
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -539,3 +541,90 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
override def prettyName: String = "str_to_map"
}
+
+/**
+ * Adds/replaces field in struct by name.
+ */
+case class WithField(structExpr: Expression, fieldName: String, valueExpr:
Expression)
+ extends Unevaluable {
+
+ private lazy val fieldPath =
CatalystSqlParser.parseMultipartIdentifier(fieldName)
Review comment:
`Expression` is a very low-level unit of SQL execution. It will be
serialized and sent to executors, and be evaluated for each task.
I think it makes more sense to parse the field name at the driver side (in
`functions.with_field`), so it's only done once.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
