cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438633426



##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -969,4 +992,7 @@ private[spark] object Executor {
   // task is fully deserialized. When possible, the 
TaskContext.getLocalProperty call should be
   // used instead.
   val taskDeserializationProps: ThreadLocal[Properties] = new 
ThreadLocal[Properties]
+
+  val MDC_KEY = "mdc."
+  val TASK_MDC_KEY = s"${MDC_KEY}taskName"

Review comment:
       It affects end-users, as now they need to use `mdc.taskName` in the 
log4j config file, instead of `taskName`.
   
   But it's not released yet, I'm fine to make it consistent that all the MDC 
properties start with `mdc.`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to