cloud-fan commented on a change in pull request #28756:
URL: https://github.com/apache/spark/pull/28756#discussion_r438650463
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -703,11 +709,10 @@ private[spark] class Executor(
}
private def setMDCForTask(taskName: String, mdc: Seq[(String, String)]):
Unit = {
- MDC.put("taskName", taskName)
-
Review comment:
can we do `MDC.clear()` at the beginning of this method? It looks safer
if we want to make sure we run the task with only the user-specified mdc
properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
