cloud-fan commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r440809637
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -539,3 +541,82 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
override def prettyName: String = "str_to_map"
}
+
+/**
+ * Adds/replaces field in struct by name.
+ */
+case class WithFields(
+ structExpr: Expression,
+ nameExprs: Seq[Expression],
+ valExprs: Seq[Expression]) extends Unevaluable {
+
+ override def checkInputDataTypes(): TypeCheckResult = {
+ val expectedStructType = StructType(Nil).typeName
+ if (structExpr.dataType.typeName != expectedStructType) {
+ TypeCheckResult.TypeCheckFailure(
+ "struct argument should be struct type, got: " +
structExpr.dataType.catalogString)
+ } else if (!nameExprs.forall(e => e.foldable && e.dataType == StringType))
{
+ TypeCheckResult.TypeCheckFailure(
+ s"nameExprs argument should contain only foldable
${StringType.catalogString} expressions")
+ } else if (nameExprs.length != valExprs.length) {
Review comment:
Can we add an assert at the beginning of the class body? This is not a
user-facing error that can be triggered by users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
