cloud-fan commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r441300305
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -539,3 +541,82 @@ case class StringToMap(text: Expression, pairDelim:
Expression, keyValueDelim: E
override def prettyName: String = "str_to_map"
}
+
+/**
+ * Adds/replaces field in struct by name.
+ */
+case class WithFields(
+ structExpr: Expression,
+ nameExprs: Seq[Expression],
+ valExprs: Seq[Expression]) extends Unevaluable {
+
+ override def checkInputDataTypes(): TypeCheckResult = {
+ val expectedStructType = StructType(Nil).typeName
+ if (structExpr.dataType.typeName != expectedStructType) {
+ TypeCheckResult.TypeCheckFailure(
+ "struct argument should be struct type, got: " +
structExpr.dataType.catalogString)
+ } else if (!nameExprs.forall(e => e.foldable && e.dataType == StringType))
{
+ TypeCheckResult.TypeCheckFailure(
+ s"nameExprs argument should contain only foldable
${StringType.catalogString} expressions")
+ } else if (nameExprs.length != valExprs.length) {
Review comment:
yea let's don't consider SQL API for now. But even for SQL API, I think
we should follow the scala API and take care of the name parsing, so that users
can't trigger this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
