wypoon commented on a change in pull request #28848:
URL: https://github.com/apache/spark/pull/28848#discussion_r441671240
##########
File path: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
##########
@@ -1939,24 +1941,22 @@ private[spark] class DAGScheduler(
hostToUnregisterOutputs: Option[String],
maybeEpoch: Option[Long] = None): Unit = {
val currentEpoch = maybeEpoch.getOrElse(mapOutputTracker.getEpoch)
+ logDebug(s"Removing executor $execId, fileLost: $fileLost, currentEpoch:
$currentEpoch")
Review comment:
See explanation in my response to your comment about the previous
logDebug.
There are now two if clauses. I think it is simpler just to log the values
at the beginning of the method; knowing the values will tell you which if
clauses will get executed. But more importantly, this logDebug tells you that
the method is invoked. Then depending on whether there is additional log
output, you know if one or both of the if clauses are executed as well. (If it
is inside an if, then you don't know if the method was invoked but if
conditions were not met.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
