viirya commented on pull request #28826:
URL: https://github.com/apache/spark/pull/28826#issuecomment-647199261


   > While v1 calls for `prunePhysicalColumns`
   > 
   > 
https://github.com/apache/spark/blob/d2a656c81ef784657a02e7347bfe87e4331fd2c9/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/SchemaPruning.scala#L63
   > 
   > and the property `root.derivedFromAtt` is set to true so the structType 
from `requestedRootFields` is not used.
   
   Thanks for the update, @guykhazma. So, does it mean if we have 
`derivedFromAtt` is false on any requested root field, v1 path will also 
discard attribute metadata. It sounds like we can also have a test case for 
that?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to