cloud-fan commented on a change in pull request #28895:
URL: https://github.com/apache/spark/pull/28895#discussion_r444000320
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -737,35 +721,21 @@ private[spark] class MapOutputTrackerMaster(
// Get blocks sizes by executor Id. Note that zero-sized blocks are excluded
in the result.
// This method is only called in local-mode.
def getMapSizesByExecutorId(
- shuffleId: Int,
- startPartition: Int,
- endPartition: Int)
- : Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = {
- logDebug(s"Fetching outputs for shuffle $shuffleId, partitions
$startPartition-$endPartition")
- shuffleStatuses.get(shuffleId) match {
- case Some (shuffleStatus) =>
- shuffleStatus.withMapStatuses { statuses =>
- MapOutputTracker.convertMapStatuses(
- shuffleId, startPartition, endPartition, statuses, 0,
shuffleStatus.mapStatuses.length)
- }
- case None =>
- Iterator.empty
- }
- }
-
- override def getMapSizesByRange(
shuffleId: Int,
startMapIndex: Int,
endMapIndex: Int,
startPartition: Int,
- endPartition: Int): Iterator[(BlockManagerId, Seq[(BlockId, Long,
Int)])] = {
- logDebug(s"Fetching outputs for shuffle $shuffleId, mappers
$startMapIndex-$endMapIndex" +
- s"partitions $startPartition-$endPartition")
+ endPartition: Int)
+ : Iterator[(BlockManagerId, Seq[(BlockId, Long, Int)])] = {
+ logDebug(s"Fetching outputs for shuffle $shuffleId")
shuffleStatuses.get(shuffleId) match {
- case Some(shuffleStatus) =>
+ case Some (shuffleStatus) =>
shuffleStatus.withMapStatuses { statuses =>
+ val endMapIndex0 = if (endMapIndex == Int.MaxValue) statuses.length
else endMapIndex
Review comment:
`actualEndMapIndex`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
