cloud-fan commented on a change in pull request #28895:
URL: https://github.com/apache/spark/pull/28895#discussion_r444004873
##########
File path: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala
##########
@@ -43,23 +44,15 @@ private[spark] trait ShuffleManager {
context: TaskContext,
metrics: ShuffleWriteMetricsReporter): ShuffleWriter[K, V]
- /**
- * Get a reader for a range of reduce partitions (startPartition to
endPartition-1, inclusive).
- * Called on executors by reduce tasks.
- */
- def getReader[K, C](
Review comment:
can we keep this method as an overload? We can mark it as final and
simply call the other `getReader` with `0, Int.Max` as the map index parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
