gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444036845



##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
         <version>8.2.2.jre8</version>
         <scope>test</scope>
       </dependency>
+      <dependency>
+        <groupId>com.oracle.database.jdbc</groupId>
+        <artifactId>ojdbc8</artifactId>
+        <version>19.6.0.0</version>
+        <scope>test</scope>
+      </dependency>

Review comment:
       This change is questionable but I think rolling this back and adding it 
in the next commit ends-up more work nominally. Apart from that purely personal 
taste but I like the dependency management way of dep handling (even if only 
one reference exists).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to