gaborgsomogyi commented on a change in pull request #28893:
URL: https://github.com/apache/spark/pull/28893#discussion_r444084912
##########
File path: pom.xml
##########
@@ -984,6 +984,12 @@
<version>8.2.2.jre8</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.oracle.database.jdbc</groupId>
+ <artifactId>ojdbc8</artifactId>
+ <version>19.6.0.0</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
Honestly not considered independency but I agree with the direction. I
would like to understand your point but not yet able. Here we're considering on
which side the dep management will be. We can consider dep management change as
an additional complexity at the top of the actual code base. If we move that
from this PR into the other one will make this more independent but on the
other side will make the other one less independent. I see this as a tradeoff.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
