cloud-fan commented on a change in pull request #28875:
URL: https://github.com/apache/spark/pull/28875#discussion_r444159685
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -347,23 +347,23 @@ case class MergeIntoTable(
}
sealed abstract class MergeAction(
- condition: Option[Expression]) extends Expression with Unevaluable {
+ val condition: Option[Expression]) extends Expression with Unevaluable {
Review comment:
to simplify the code a little bit:
```
sealed trait MergeAction extends Expression with Unevaluable {
def condition: Option[Expression]
...
}
```
Then we can just write
```
case class DeleteAction(condition: Option[Expression]) extends MergeAction
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
