siknezevic commented on a change in pull request #27246:
URL: https://github.com/apache/spark/pull/27246#discussion_r444591210
##########
File path:
sql/core/benchmarks/ExternalAppendOnlyUnsafeRowArrayBenchmark-results.txt
##########
@@ -42,4 +42,8 @@ Spilling with 10000 rows: Best Time(ms) Avg
Time(ms) Stdev(m
UnsafeExternalSorter 11 11
1 14.7 68.0 1.0X
ExternalAppendOnlyUnsafeRowArray 9 10
1 17.1 58.5 1.2X
-
+OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~16.04-b09 on Linux
4.4.0-178-generic
Review comment:
One more thing, we will not see performance improvements for the
existing benchmarks if the benchmark iterates over the spilled data. Then
comparison will be related to the machine on which benchmark was running and
disk speed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
