siknezevic commented on a change in pull request #27246:
URL: https://github.com/apache/spark/pull/27246#discussion_r445304792
##########
File path:
sql/core/benchmarks/ExternalAppendOnlyUnsafeRowArrayBenchmark-results.txt
##########
@@ -42,4 +42,8 @@ Spilling with 10000 rows: Best Time(ms) Avg
Time(ms) Stdev(m
UnsafeExternalSorter 11 11
1 14.7 68.0 1.0X
ExternalAppendOnlyUnsafeRowArray 9 10
1 17.1 58.5 1.2X
-
+OpenJDK 64-Bit Server VM 1.8.0_252-8u252-b09-1~16.04-b09 on Linux
4.4.0-178-generic
Review comment:
Yes, I did comparison of the existing micro-benchmark results when patch
is applied and when there is no patch.
I do not see regression in the performance for the existing
micro-benchmarks. I will push micro-benchmark results for jdk11 soon.
Thank you for help 😊
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
