cloud-fan commented on a change in pull request #28805:
URL: https://github.com/apache/spark/pull/28805#discussion_r444662496
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -211,7 +211,9 @@ trait PredicateHelper extends Logging {
* @return the CNF result as sequence of disjunctive expressions. If the
number of expressions
* exceeds threshold on converting `Or`, `Seq.empty` is returned.
*/
- protected def conjunctiveNormalForm(condition: Expression): Seq[Expression]
= {
+ protected def conjunctiveNormalForm(
+ condition: Expression,
+ groupExpsFunc: Seq[Expression] => Seq[Expression] = _.toSeq):
Seq[Expression] = {
Review comment:
nit: do we really need a default value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
