cloud-fan commented on a change in pull request #28805:
URL: https://github.com/apache/spark/pull/28805#discussion_r446968910
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -249,8 +251,16 @@ trait PredicateHelper extends Logging {
resultStack.top
}
- private def groupExpressionsByQualifier(expressions: Seq[Expression]):
Seq[Expression] = {
-
expressions.groupBy(_.references.map(_.qualifier)).map(_._2.reduceLeft(And)).toSeq
+ def conjunctiveNormalFormAndGroupExpsByQualifier(condition: Expression):
Seq[Expression] = {
Review comment:
not related to this PR but it's great if we can add comments here too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
