Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/538#discussion_r12016093
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
    @@ -114,7 +118,7 @@ private[spark] class EventLoggingListener(
        * In addition, create an empty special file to indicate application 
completion.
        */
       def stop() = {
    -    logger.newFile(APPLICATION_COMPLETE)
    +    logger.newFile(APPLICATION_COMPLETE, Some(LOG_FILE_PERMISSIONS))
    --- End diff --
    
    It's a little awkward that every time we create a new file we pass in 
`Some(LOG_FILE_PERMISSIONS)`. I think in `FileLogger` we should check if the 
logger has a permissions and default on it if it does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to