Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/538#discussion_r12016182
--- Diff: core/src/main/scala/org/apache/spark/util/FileLogger.scala ---
@@ -97,11 +106,11 @@ private[spark] class FileLogger(
// Second parameter is whether to append
new FileOutputStream(uri.getPath, !overwrite)
} else {
- val path = new Path(logPath)
hadoopDataStream = Some(fileSystem.create(path, overwrite))
hadoopDataStream.get
}
+ perms.foreach {p => fileSystem.setPermission(path, p)}
--- End diff --
Here I would do `perms.orElse(dirPermissions).foreach { ... }`, so we fall
back on the logger's permissions if they exist. That way if we intend for all
our files to have one set of permissions (e.g. in event logging) we don't have
to provide `Some(permissions)` every time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
