maropu commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r445510771
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -32,7 +32,9 @@ object NestedColumnAliasing {
def unapply(plan: LogicalPlan): Option[LogicalPlan] = plan match {
case Project(projectList, child)
- if SQLConf.get.nestedSchemaPruningEnabled &&
canProjectPushThrough(child) =>
+ if SQLConf.get.nestedSchemaPruningEnabled &&
+ (canProjectPushThrough(child) ||
+ getChild(child).exists(canProjectPushThrough)) =>
Review comment:
Is this correct? I'm not 100% sure that this matching case can handle
this condition: `Project->[*Any* logical unary node]->[Logical node that can be
pushed through]`. Anyway, we need more tests for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
