viirya commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r445623584
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -32,7 +32,9 @@ object NestedColumnAliasing {
def unapply(plan: LogicalPlan): Option[LogicalPlan] = plan match {
case Project(projectList, child)
- if SQLConf.get.nestedSchemaPruningEnabled &&
canProjectPushThrough(child) =>
+ if SQLConf.get.nestedSchemaPruningEnabled &&
+ (canProjectPushThrough(child) ||
+ getChild(child).exists(canProjectPushThrough)) =>
Review comment:
How about use my proposal?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -32,7 +32,9 @@ object NestedColumnAliasing {
def unapply(plan: LogicalPlan): Option[LogicalPlan] = plan match {
case Project(projectList, child)
- if SQLConf.get.nestedSchemaPruningEnabled &&
canProjectPushThrough(child) =>
+ if SQLConf.get.nestedSchemaPruningEnabled &&
+ (canProjectPushThrough(child) ||
+ getChild(child).exists(canProjectPushThrough)) =>
Review comment:
I don't think this is correct fix. It will push through a child that
should not be pushed through.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
