maropu commented on a change in pull request #28898:
URL: https://github.com/apache/spark/pull/28898#discussion_r446499910
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasingSuite.scala
##########
@@ -493,6 +491,58 @@ class NestedColumnAliasingSuite extends SchemaPruningTest {
comparePlans(optimized3, expected3)
}
+ test("Nested field pruning for window functions") {
+ val spec = windowSpec($"address" :: Nil, $"id".asc :: Nil,
UnspecifiedFrame)
+ val winExpr = windowExpr(RowNumber().toAggregateExpression(), spec)
+ val query = contact.select($"name.first", winExpr.as('window))
+ .where($"window" === 1 && $"name.first" === "a")
+ .analyze
+ val optimized = Optimize.execute(query)
+ val aliases = collectGeneratedAliases(optimized)
+ val expected = contact
+ .select($"name.first", $"address", $"id", $"name.first".as(aliases(1)))
+ .window(Seq(winExpr.as("window")), Seq($"address"), Seq($"id".asc))
+ .select($"first", $"${aliases(1)}".as(aliases(0)), $"window")
+ .where($"window" === 1 && $"${aliases(0)}" === "a")
Review comment:
Just a suggestion: could you remove this `where` in this test, then add
a separate test unit like `test("Nested field pruning for Filter") {` for
exhaustive filter tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
