Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5085#discussion_r26985197
--- Diff: launcher/src/main/java/org/apache/spark/launcher/Main.java ---
@@ -47,10 +47,14 @@
* character. On Windows, the output is a command line suitable for
direct execution from the
* script.
*/
+
+ static String uberJarPath;
--- End diff --
This looks really ugly. I'd really prefer plumbing this to the command
builders through the constructor. It's a little bit more code but much cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
