cloud-fan commented on a change in pull request #28882:
URL: https://github.com/apache/spark/pull/28882#discussion_r446768236
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -545,7 +545,11 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
}
private def getLocationFromStorageProps(table: CatalogTable): Option[String]
= {
- CaseInsensitiveMap(table.storage.properties).get("path")
+ if (conf.get(HiveUtils.FOLLOW_TABLE_LOCATION)) {
Review comment:
It looks tricky to have a config for such a subtle behavior. I think it
makes more sense to fail when the path serde property doesn't match the table
location, and ask users to either correct the path property or the table
location.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
