cloud-fan commented on a change in pull request #28882:
URL: https://github.com/apache/spark/pull/28882#discussion_r447758438
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala
##########
@@ -545,7 +545,14 @@ private[spark] class HiveExternalCatalog(conf: SparkConf,
hadoopConf: Configurat
}
private def getLocationFromStorageProps(table: CatalogTable): Option[String]
= {
- CaseInsensitiveMap(table.storage.properties).get("path")
+ val storageLoc = table.storage.locationUri.map(_.toString)
+ val storageProp = CaseInsensitiveMap(table.storage.properties).get("path")
Review comment:
I'm a bit worried about string comparison. Are you sure the path string
is always equal to the URI string? Shall we do normalization before comparing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
