cloud-fan commented on a change in pull request #28629:
URL: https://github.com/apache/spark/pull/28629#discussion_r446768786
##########
File path: core/src/test/scala/org/apache/spark/util/ThreadUtilsSuite.scala
##########
@@ -25,11 +25,27 @@ import scala.concurrent.duration._
import scala.util.Random
import org.scalatest.concurrent.Eventually._
+import org.slf4j.MDC
import org.apache.spark.SparkFunSuite
class ThreadUtilsSuite extends SparkFunSuite {
+ test("newDaemonSingleThreadExecutor with MDC") {
+ val appIdValue = s"appId-${System.currentTimeMillis()}"
+ MDC.put("appId", appIdValue)
Review comment:
I'm still worried about API inconsistency. We should use either
`sc.setLocalProperties` or `MDC.put` for both driver and executor side MDC
properties.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
