attilapiros commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446882734
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -27,7 +27,7 @@
public class ExecutorDiskUtils {
- private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile(File.separator + "{2,}");
+ private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile("[/\\\\]+");
Review comment:
That RegExp was coming from here:
https://github.com/apache/spark/blob/master/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java#L74
(Actually as I see no one is referencing
`ExternalShuffleBlockResolver#MULTIPLE_SEPARATORS` so it can be removed.)
So now I am wondering if the original regexp is is so old and even
backported to 2.2: https://github.com/apache/spark/pull/21456 whether this
change is really necessary.
I plan to boot a windows and so some checks there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
