HyukjinKwon commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446887373
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -27,7 +27,7 @@
public class ExecutorDiskUtils {
- private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile(File.separator + "{2,}");
+ private static final Pattern MULTIPLE_SEPARATORS =
Pattern.compile("[/\\\\]+");
Review comment:
Hm, that one would probably need to fix too. I sort of audited and
managed to make all tests pass on Windows .. but seems like there are a bunch
of new instances to fix again ..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
