Ngone51 commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446943605
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExecutorDiskUtils.java
##########
@@ -41,6 +48,13 @@ public static File getFile(String[] localDirs, int
subDirsPerLocalDir, String fi
localDir, String.format("%02x", subDirId), filename));
}
+ /** Returns whether the OS is Windows. */
+ @VisibleForTesting
+ static boolean isWindows() {
+ String os = System.getProperty("os.name");
+ return os.startsWith("Windows");
+ }
Review comment:
I see. Then, could we also use
`org.apache.commons.lang3.SystemUtils.IS_OS_WINDOWS` for simplicity?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
