attilapiros commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r446937653
##########
File path:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
##########
@@ -146,12 +146,25 @@ public void jsonSerializationOfExecutorRegistration()
throws IOException {
@Test
public void testNormalizeAndInternPathname() {
- assertPathsMatch("/foo", "bar", "baz", "/foo/bar/baz");
- assertPathsMatch("//foo/", "bar/", "//baz", "/foo/bar/baz");
- assertPathsMatch("foo", "bar", "baz///", "foo/bar/baz");
- assertPathsMatch("/foo/", "/bar//", "/baz", "/foo/bar/baz");
- assertPathsMatch("/", "", "", "/");
- assertPathsMatch("/", "/", "/", "/");
+ assertPathsMatch("/foo", "bar", "baz",
+ File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
+ assertPathsMatch("//foo/", "bar/", "//baz",
+ File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
+ assertPathsMatch("foo", "bar", "baz///",
+ "foo" + File.separator + "bar" + File.separator + "baz");
+ assertPathsMatch("/foo/", "/bar//", "/baz",
+ File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
+ assertPathsMatch("/", "", "",
+ File.separator);
+ assertPathsMatch("/", "/", "/",
+ File.separator);
+ if (ExecutorDiskUtils.isWindows()) {
+ assertPathsMatch("/foo\\/", "bar", "baz",
+ File.separator + "foo" + File.separator + "bar" + File.separator
+ "baz");
Review comment:
I agree it would better to have it as rule but from the start as now
there are many violations. If you would correct all of them with 1 commit than
git blame would be a bit harder to use a blame would show your commit first on
a line where we definitely would be more interested about the feature/bug which
touched it before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
