attilapiros commented on pull request #28940: URL: https://github.com/apache/spark/pull/28940#issuecomment-651772632
We have to measure it for sure. Regarding simplicity of the solution I described it is basically sth like: https://github.com/attilapiros/spark/commit/926ebbd417f49fe2897bf29dfaa3b17178bbbdaf And I checked the prefixLength calculation they are O(1): - https://github.com/openjdk/jdk/blob/jdk8-b120/jdk/src/windows/classes/java/io/WinNTFileSystem.java#L206-L223 - https://github.com/openjdk/jdk/blob/jdk8-b120/jdk/src/solaris/classes/java/io/UnixFileSystem.java#L96-L99 For sure we can do it in separate PR too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
