pan3793 commented on a change in pull request #28940:
URL: https://github.com/apache/spark/pull/28940#discussion_r447727579
##########
File path:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
##########
@@ -147,22 +147,20 @@ public void jsonSerializationOfExecutorRegistration()
throws IOException {
@Test
public void testNormalizeAndInternPathname() {
- assertPathsMatch("/foo", "bar", "baz",
- File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
- assertPathsMatch("//foo/", "bar/", "//baz",
- File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
- assertPathsMatch("foo", "bar", "baz///",
- "foo" + File.separator + "bar" + File.separator + "baz");
- assertPathsMatch("/foo/", "/bar//", "/baz",
- File.separator + "foo" + File.separator + "bar" + File.separator +
"baz");
- assertPathsMatch("/", "", "", File.separator);
- assertPathsMatch("/", "/", "/", File.separator);
+ String sep = File.separator;
+ String expectedPathname1 = sep + "foo" + sep + "bar" + sep + "baz";
Review comment:
OK, reverted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
